Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated intl*properties #6053

Merged
merged 4 commits into from
Dec 15, 2022
Merged

refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated intl*properties #6053

merged 4 commits into from
Dec 15, 2022

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Dec 15, 2022 •
edited
Loading

BREAKING CHANGE: Removed deprecated intl* & accessible label properties.

  • rating:

    • Removed the property intlStars , use messsageOverrides.stars instead.
    • Removed the property intlRating , use messsageOverrides.rating instead.

  • scrim:

    • Removed the property intlLoading , use messsageOverrides.loading instead.

  • time-picker:

    • Removed the property intlHour, use messsageOverrides.hour instead.
    • Removed the property intlHourDown, use messsageOverrides.hourDown instead.
    • Removed the property intlHourUp, use messsageOverrides.hourUp instead.
    • Removed the property intlMeridiem, use messsageOverrides.meridiem instead.
    • Removed the property intlMeridiemDown, use messsageOverrides.meridiemDown instead.
    • Removed the property intlMeridiemUp, use messsageOverrides.meridiemUp instead.
    • Removed the property intlMinute, use messsageOverrides.minute instead.
    • Removed the property intlMinuteUp, use messsageOverrides.minuteUp instead.
    • Removed the property intlMinuteDown, use messsageOverrides.minuteDown instead.
    • Removed the property intlSecond, use messsageOverrides.second instead.
    • Removed the property intlSecondUp, use messsageOverrides.secondUp instead.
    • Removed the property intlSecondDown, use messsageOverrides.secondDown instead.

  • input-time-picker:

    • Removed the property intlHour, use messsageOverrides.hour instead.
    • Removed the property intlHourDown, use messsageOverrides.hourDown instead.
    • Removed the property intlHourUp, use messsageOverrides.hourUp instead.
    • Removed the property intlMeridiem, use messsageOverrides.meridiem instead.
    • Removed the property intlMeridiemDown, use messsageOverrides.meridiemDown instead.
    • Removed the property intlMeridiemUp, use messsageOverrides.meridiemUp instead.
    • Removed the property intlMinute, use messsageOverrides.minute instead.
    • Removed the property intlMinuteUp, use messsageOverrides.minuteUp instead.
    • Removed the property intlMinuteDown, use messsageOverrides.minuteDown instead.
    • Removed the property intlSecond, use messsageOverrides.second instead.
    • Removed the property intlSecondUp, use messsageOverrides.secondUp instead.
    • Removed the property intlSecondDown, use messsageOverrides.secondDown instead.

  • value-list:

    • Removed the property intlDragHandleActive , use messsageOverrides.dragHandleActive instead.
    • Removed the property intlDragHandleChange , use messsageOverrides.dragHandleChange instead.
    • Removed the property intlDragHandleCommit , use messsageOverrides.dragHandleCommit instead.
    • Removed the property intlDragHandleIdle , use messsageOverrides.dragHandleIdle instead.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 15, 2022
@anveshmekala anveshmekala added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Dec 15, 2022
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 15, 2022
@anveshmekala anveshmekala changed the title refactor(scrim,rating,time-picker,value-list): removed deprecated intl*properties refactor(scrim,rating,time-picker,value-list)!: removed deprecated intl*properties Dec 15, 2022
@anveshmekala anveshmekala changed the title refactor(scrim,rating,time-picker,value-list)!: removed deprecated intl*properties refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated intl*properties Dec 15, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 15, 2022 02:46
@anveshmekala anveshmekala requested a review from a team as a code owner December 15, 2022 02:46
driskull
driskull approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@anveshmekala anveshmekala merged commit 7dd5a38 into master Dec 15, 2022
@anveshmekala anveshmekala deleted the anveshmekala/5946-remove-intl-deprecations-StoV branch December 15, 2022 15:24
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 15, 2022
benelan added a commit that referenced this pull request Dec 15, 2022
@benelan
Merge branch 'master' into benelan/delegatesFocus-no-mock-disabled
9030f13 
* master: (21 commits)
  1.0.0-next.685
  refactor(modal)!: Renamed property and updated values (#6054)
  1.0.0-next.684
  refactor(tab-nav, tab-title)!: remove `event.detail` payload from events (#6046)
  refactor(tree)!: remove `event.detail` payload from events (#6051)
  docs(changelog): fix breaking change indent levels (#6057)
  1.0.0-next.683
  refactor(pagination)!: remove `event.detail` payload from events (#6047)
  refactor(dropdown)!: remove `event.detail` payload from events (#6044)
  refactor(rating)!: remove `event.detail` payload from events (#6045)
  refactor(inline-editable,input,input-text,input-number)!: remove deprecated `intl*` properties (#6049)
  1.0.0-next.682
  refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated `intl*`properties (#6053)
  docs: update component READMEs (#6052)
  1.0.0-next.681
  refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker): remove deprecated `intl*` & accessible label properties (#6041)
  refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated `intl*` properties (#5982)
  1.0.0-next.680
  refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename `disable*` properties (#6036)
  refactor(input-date-picker)!: Remove deprecated calciteDatePickerChange event (#6040)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @driskull